node-week3/Niloufar #225
Open
node-week3/Niloufar #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| console.log("SQL", query.toSQL().sql); |
There was a problem hiding this comment.
🤩 debug statement!! Thank you!!.. normally when we are done debugging we remove them in order not to pollute the server output
|
|
||
| if ("sort" in req.query) { | ||
| const orderBy = req.query.sort.toString(); | ||
| if (orderBy === "first_name"){ |
There was a problem hiding this comment.
the input query parameter will be first_name%20ASC, meaning sort by first name ascending. so orderby check here would be
if (orderBy === "first_name ASC"){ //... }
the same for orderBy last name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql.injection.mp4